From 747c3f11715f1675101fc87326d3682ddce51d44 Mon Sep 17 00:00:00 2001
From: savagebidoof <filter.oriol@gmail.com>
Date: Mon, 15 May 2023 15:22:43 +0200
Subject: [PATCH] Documented `02-egress-proxy`.

Not to brag, BUT I believe it's fairly godlike.
---
 05-Sidecar/02-egress-proxy/01-namespace.yaml |  9 +-----
 05-Sidecar/02-egress-proxy/Deployment.yaml   | 29 +-------------------
 05-Sidecar/02-egress-proxy/README.md         |  2 +-
 05-Sidecar/02-egress-proxy/Sidecar.yaml      | 24 ----------------
 4 files changed, 3 insertions(+), 61 deletions(-)

diff --git a/05-Sidecar/02-egress-proxy/01-namespace.yaml b/05-Sidecar/02-egress-proxy/01-namespace.yaml
index 44d6408..418aa23 100755
--- a/05-Sidecar/02-egress-proxy/01-namespace.yaml
+++ b/05-Sidecar/02-egress-proxy/01-namespace.yaml
@@ -3,11 +3,4 @@ kind: Namespace
 metadata:
   name: foo
   labels:
-    istio-injection: "enabled"
-#---
-#apiVersion: v1
-#kind: Namespace
-#metadata:
-#  name: test
-#  labels:
-#    istio-injection: "enabled"
\ No newline at end of file
+    istio-injection: "enabled"
\ No newline at end of file
diff --git a/05-Sidecar/02-egress-proxy/Deployment.yaml b/05-Sidecar/02-egress-proxy/Deployment.yaml
index 80999e6..ac7ce0a 100755
--- a/05-Sidecar/02-egress-proxy/Deployment.yaml
+++ b/05-Sidecar/02-egress-proxy/Deployment.yaml
@@ -50,31 +50,4 @@ spec:
               cpu: "100m"
           imagePullPolicy: IfNotPresent #Always
           ports:
-            - containerPort: 80
-#---
-#apiVersion: apps/v1
-#kind: Deployment
-#metadata:
-#  name: helloworld-test
-#  labels:
-#    app: helloworld
-#  namespace: test
-#spec:
-#  replicas: 1
-#  selector:
-#    matchLabels:
-#      app: helloworld
-#  template:
-#    metadata:
-#      labels:
-#        app: helloworld
-#    spec:
-#      containers:
-#        - name: helloworld
-#          image: nginx
-#          resources:
-#            requests:
-#              cpu: "100m"
-#          imagePullPolicy: IfNotPresent #Always
-#          ports:
-#            - containerPort: 80
+            - containerPort: 80
\ No newline at end of file
diff --git a/05-Sidecar/02-egress-proxy/README.md b/05-Sidecar/02-egress-proxy/README.md
index 3bed1d9..10c6ca0 100755
--- a/05-Sidecar/02-egress-proxy/README.md
+++ b/05-Sidecar/02-egress-proxy/README.md
@@ -734,5 +734,5 @@ sidecar.networking.istio.io "helloworld-sidecar-foo" deleted
 - https://istio.io/latest/blog/2019/monitoring-external-service-traffic/#what-are-blackhole-and-passthrough-clusters
 
 - https://istio.io/v1.0/help/ops/traffic-management/proxy-cmd/#deep-dive-into-envoy-configuration
-- 
+
 - https://istio.io/latest/docs/reference/commands/pilot-discovery/#pilot-discovery-completion
\ No newline at end of file
diff --git a/05-Sidecar/02-egress-proxy/Sidecar.yaml b/05-Sidecar/02-egress-proxy/Sidecar.yaml
index 78cd993..f73fcb0 100755
--- a/05-Sidecar/02-egress-proxy/Sidecar.yaml
+++ b/05-Sidecar/02-egress-proxy/Sidecar.yaml
@@ -1,15 +1,3 @@
-#apiVersion: networking.istio.io/v1alpha3
-#kind: Sidecar
-#metadata:
-#  name: global-sidecar
-#  namespace: istio-system
-#spec:
-#  egress:
-#    - hosts:
-#      - "./*"
-#  outboundTrafficPolicy:
-#    mode: REGISTRY_ONLY
----
 apiVersion: networking.istio.io/v1alpha3
 kind: Sidecar
 metadata:
@@ -25,8 +13,6 @@ spec:
         protocol: HTTP
         name: egress-http
       hosts:
-#        - "./*"
-#        - "istio-system/*"
         - "foo/*"
   outboundTrafficPolicy:
     mode: REGISTRY_ONLY
@@ -47,16 +33,6 @@ spec:
         name: egress-default
       hosts:
         - "default/*"
-#    - port:
-#        number: 80
-#        protocol: HTTP
-#        name: egress-foo
-#      hosts:
         - "./*"
-#- "./*"
-  #        - "default/helloworld.default.svc.cluster.local"
-  #        - "*/*"
-  #        - "default/helloworld.default.svc.cluster.local"
-  #        - "foo/*"
   outboundTrafficPolicy:
     mode: REGISTRY_ONLY
\ No newline at end of file